http: bound chunked framing lines and answer malformed bodies with 400 - #3721
Merged
Conversation
A chunk-size line or trailer with no terminator was reread in full on every socket read and had no size limit; cap it and keep the scan position.
benoitc
force-pushed
the
fix/chunked-quadratic-cpu
branch
2 times, most recently
from
August 30, 2026 22:18
d6c55d2 to
55f6c02
Compare
Classify the chunk framing errors as parse errors so they return 400 instead of a logged traceback.
benoitc
force-pushed
the
fix/chunked-quadratic-cpu
branch
from
August 30, 2026 22:48
55f6c02 to
e66a15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A chunk-size line or trailer with no terminator was reread in full on every socket read and had no size limit, so a single request could keep a worker busy and never reach the application.
Cap those lines by the existing request limits, keep the scan position instead of rescanning, and return
400 Bad Requestfor a malformed chunked body instead of a logged traceback.