Skip to content

test: catch every transport error in the docker health check #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benoitc merged 1 commit into from
Aug 18, 2026
+2 −2
Merged

test: catch every transport error in the docker health check #3698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/docker/asgi_framework_compat/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def wait_for_service(url: str, timeout: int = 180) -> bool:
response = httpx.get(f"{url}/health", timeout=5.0)
if response.status_code == 200:
return True
except (httpx.ConnectError, httpx.TimeoutException):
except httpx.RequestError:
pass
time.sleep(1)
return False
Expand All @@ -105,7 +105,7 @@ def docker_services(docker_compose_file, request):
if response.status_code != 200:
all_healthy = False
break
except (httpx.ConnectError, httpx.TimeoutException):
except httpx.RequestError:
all_healthy = False
break

Expand Down