Skip to content

chore: minimise dependency on the Python package named 'packaging' - #3643

Merged
benoitc merged 2 commits into
benoitc:masterfrom
openculinary:discussion-3608/minimise-packaging-dependency
Aug 17, 2026
Merged

chore: minimise dependency on the Python package named 'packaging'#3643
benoitc merged 2 commits into
benoitc:masterfrom
openculinary:discussion-3608/minimise-packaging-dependency

Conversation

@jayaddison

Copy link
Copy Markdown
Contributor

The Python package named packaging is only required as a runtime dependency by the gevent worker of gunicorn; in other words, we do not need to install it as a dependency for installations of other worker types.

This changeset relocates the packaging requirement from the default dependencies for gunicorn to the gevent extras set (and also the requirements_test.txt requirements file, so that it is available when the unit tests run).

Resolves #3608 (discussion thread).

The Python package named `packaging` is only required as a
runtime dependency by the `gevent` worker of `gunicorn`; in
other words, we do not need to install it as a dependency
for installations of other worker types.

This changeset relocates the `packaging` requirement from
the default dependencies for `gunicorn` to the `gevent` extras
set (and also the `requirements_test.txt` requirements file, so
that it is available when the unit tests run).
Comment thread pyproject.toml
"gevent>=24.10.1",
"h2>=4.1.0",
"coverage",
"packaging",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: I didn't mention this additional line when I wrote the discussion thread topic; I noticed it today while scanning the pyproject.toml file again. It seems to more-or-less mirror the requirement list in requirements_test.txt, so I've added packaging here too, for consistency.

@jeffsawatzky

Copy link
Copy Markdown

@jayaddison seems like it is failing a lint test. Looks simple enough to fix.

@jayaddison

This comment was marked as resolved.

@jayaddison

Copy link
Copy Markdown
Contributor Author

@jeffsawatzky

@jayaddison seems like it is failing a lint test. Looks simple enough to fix.

That has now been resolved by (unrelated) pull request #3651.

@jayaddison

Copy link
Copy Markdown
Contributor Author

@benoitc ping?

@jayaddison

Copy link
Copy Markdown
Contributor Author

@tilgovi ping?

@benoitc
benoitc merged commit 3e0ed73 into benoitc:master Aug 17, 2026
12 checks passed
@jayaddison

Copy link
Copy Markdown
Contributor Author

Thanks @benoitc!

@jayaddison
jayaddison deleted the discussion-3608/minimise-packaging-dependency branch August 17, 2026 15:02
@benoitc benoitc mentioned this pull request Aug 17, 2026
benoitc added a commit that referenced this pull request Aug 18, 2026
Add the three changelog entries that were missing since 26.0.0: the
truncated chunked body fix (#3382), the --spew indexing fix (#3344) and
dropping packaging from the runtime dependencies (#3643).

Promote Unreleased to 26.1.0 and mirror the section into the Latest
changelog page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants