style: argparse inheritance, hide some options from --help - #3272
Closed
pajod wants to merge 3 commits into
Closed
Conversation
removed in 27cc404
Owner
|
Closing this PR as it's primarily a style change that has been open for over a year. Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea: We could hide deprecated ones from
--help, and possibly move both unstable and deprecated ones to their own, bottom-most section in the documentation.Attached patch hacks (style improvements welcome) the config.py-class-to-argparse code so we can subclass while keeping metaclass intact. Then it adds a
Deprecatedclass that hides certain settings from--help. I tried to avoid additional functional changes.If this PR moves forward with minor changes, then the following changes are the next steps:
--user/--groupunset should mean do not do that - see clearly point out the surprising behavior of --reload, --user, --group, --config (+ unlock a few previously impossible combinations) #3360None-like value--config=""should mean do not read config (as in:--config=/dev/null) - see clearly point out the surprising behavior of --reload, --user, --group, --config (+ unlock a few previously impossible combinations) #3360--bind fd://3whenLISTEN_FDS=1set can be erratic & surprisingtmp_upload_dirsetting actually do anything? #3349