Skip to content

p#2

Open
ddarvish wants to merge 3 commits into
benklop:portnfixfrom
FisHlaBsoMAN:portnfix
Open

p#2
ddarvish wants to merge 3 commits into
benklop:portnfixfrom
FisHlaBsoMAN:portnfix

Conversation

@ddarvish

Copy link
Copy Markdown

[u;;

Ben Klopfenstein and others added 3 commits June 29, 2018 16:23
I returned the use of DEVICE_ID from the config file.
Added a bunch of useless spaces. Or not me, but pycharm. Pycharm helped me a lot with debugging.
Small cosmetic changes in the names of variables.
added a lot of debugging garbage. Sorry.. I still do not understand how it works. Perhaps you need to go back to the code at least a couple of times
a month, not half a year.
wrote a lot of TODO's.
Added symlinks, to prevent duplicates. Since I made a big dump from the aritist's then the tracks in the albums lead to other folders .. or maybe I
had to simlink albums? But still I'm not sure how best to allocate it, can it be reduced to the grouping of performers by ARTIST_ID?
The paths to the main file are taken by the artist's name, which means that /album_artist/album/track.mp3 is a symlink.
Has commented that that .. More correctly reception of covers at start, playlists and still that that.
broke playlists.
broke the full list of tracks (and did I add it earlier?).
to practice shamanism with covers. seem to work.
I do not understand how to calculate the size of the file on the server and how to get it entirely (file). I can not get the last few kilobytes of
the track - the server returns a void, although wget download entirely.
that something is broken in the buffering and loading and in general all this should be thrown out entirely and rewritten to async or something else,
but I do not know how yet.
It is necessary to rewrite the closing of files .. there may be several openings to 1 track, but the closure is one and it destroys the data. it is
necessary to move the closing mechanism to the track ... and generally keep the tracks in memory .... at least not to keep them entirely or to throw
them to the disc.
Since I added line filtering, then obviously there was a bunch of bugs .. well, in general, somewhere I forgot something and also the proximity.
bytes ... bytesarray .. and burn it with a blue flame. What a bug healed already do not remember when.
Cyrillic? I cleaned it.
Add sample config. ~/gmusicfs/gmusicfs    May be rename to credi...s/config/password/?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants