Repository navigation
Find the SidePulse Dot, which mounts as PulseDot - #3
Merged
Merged
Conversation
The plugin matched only volume names that start with "sidepulse". The Dot uses a FAT12 volume, and a FAT label holds 11 characters at most. Its label is "PulseDot", so the plugin never found the device and stayed silent. The upstream sidepulse app also matches "pulsedot". The self-check now tests the three known volume names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin did not find a SidePulse Dot. This change makes it find the Dot and write the LED states to it.
Problem
The plugin matched only volume names that start with
sidepulse. The Dot uses a FAT12 volume, and a FAT label holds 11 characters at most. The label of the Dot isPulseDot, somount()returned nothing. The plugin then stayed silent, and nothing reported an error.The upstream sidepulse app also matches
pulsedot(DEVICE_NAME_HINTSindevice_writer.py).Fix
VOLUME = /^(sidepulse|pulsedot)/ireplaces the inline regex inmount().SidePulse,SidePulsePro, andPulseDot, and makes sure thatMacintosh HDdoes not match.How to test
On a Mac with a SidePulse Dot plugged in, run this from a clone of this branch:
Expected output, first two lines:
On
main, the second line isdevice not mounted. I tested both on macOS 26.4.1 (Apple Silicon) with Node v26.12.1.