Repository navigation
Fix build warnings and Docker CI workflow - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses build warnings and improves the Docker CI workflow by cleaning up build artifacts and making the Docker build process non-interactive. The changes ensure proper ELF segment separation, add missing dependencies, and provide guidance for automated agents.
Changes:
- Added PHDRS to linker script to separate read-execute and read-write segments, eliminating RWX kernel segment warnings
- Added
dosfstoolsdependency to Dockerfile and README.md for consistency - Changed ESP filesystem from FAT32 to FAT16 (more appropriate for 16MB volumes) and enhanced ISO structure
- Made Docker build non-interactive by removing
-tiflags and added boot menu options to QEMU scripts - Added AGENTS.md file with repository guidance including mandatory PR workflow
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| kernel/linker.ld | Added PHDRS section to separate text (R-X) and data (RW-) segments, eliminating RWX warnings |
| kernel/main.c | Added __attribute__((noreturn)) to halt_forever declaration for proper compiler hints |
| Makefile | Changed FAT32→FAT16, added ISO boot directory structure, removed -ti for non-interactive Docker builds |
| Dockerfile | Added dosfstools package dependency |
| README.md | Added dosfstools to installation instructions |
| tools/qemu-run.sh | Added -boot order=d,menu=on flags for explicit boot configuration |
| tools/qemu-gdb.sh | Added -boot order=d,menu=on flags for explicit boot configuration |
| AGENTS.md | New file providing repository guidance for automated tools |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing