Skip to content

Fix build warnings and Docker CI workflow - #1

Merged
ben001109 merged 1 commit into
mainfrom
fix/build-warnings
Jan 19, 2026
Merged

ben001109 merged 1 commit into
mainfrom
fix/build-warnings

Conversation

@ben001109

Copy link
Copy Markdown
Owner

Summary

  • add AGENTS guidance including mandatory PR workflow
  • clean up build artifacts to avoid RWX kernel segment and ESP/ISO warnings
  • make Docker build path non-interactive and align deps with docs

Testing

  • docker run --rm --platform=linux/amd64 -v "$(pwd)":/work -w /work starforge-build bash -lc 'make clean && make -j$(nproc)'
  • make docker-make

Copilot AI review requested due to automatic review settings January 18, 2026 02:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses build warnings and improves the Docker CI workflow by cleaning up build artifacts and making the Docker build process non-interactive. The changes ensure proper ELF segment separation, add missing dependencies, and provide guidance for automated agents.

Changes:

  • Added PHDRS to linker script to separate read-execute and read-write segments, eliminating RWX kernel segment warnings
  • Added dosfstools dependency to Dockerfile and README.md for consistency
  • Changed ESP filesystem from FAT32 to FAT16 (more appropriate for 16MB volumes) and enhanced ISO structure
  • Made Docker build non-interactive by removing -ti flags and added boot menu options to QEMU scripts
  • Added AGENTS.md file with repository guidance including mandatory PR workflow

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
kernel/linker.ld Added PHDRS section to separate text (R-X) and data (RW-) segments, eliminating RWX warnings
kernel/main.c Added __attribute__((noreturn)) to halt_forever declaration for proper compiler hints
Makefile Changed FAT32→FAT16, added ISO boot directory structure, removed -ti for non-interactive Docker builds
Dockerfile Added dosfstools package dependency
README.md Added dosfstools to installation instructions
tools/qemu-run.sh Added -boot order=d,menu=on flags for explicit boot configuration
tools/qemu-gdb.sh Added -boot order=d,menu=on flags for explicit boot configuration
AGENTS.md New file providing repository guidance for automated tools

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ben001109
ben001109 merged commit 74e8f10 into main Jan 19, 2026
7 checks passed
@ben001109
ben001109 deleted the fix/build-warnings branch January 19, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants