build: remove the PHPStan 2.2.6 exclusion - #115
Merged
Conversation
Rector 2.5.8 contains the upstream fix for the PHPStan 2.2.6 startup failure. Remove the exclusion from the phpstan/phpstan constraint. Raise the development floors to phpstan/phpstan ^2.2 and rector/rector ^2.5. Update the lock file to PHPStan 2.2.6 and Rector 2.5.8. Apply the one change that RemoveDefaultValueFromAssignedPropertyRector reports with Rector 2.5.8. Closes #86
marmichalski
marked this pull request as ready for review
July 27, 2026 14:12
marmichalski
enabled auto-merge (squash)
July 27, 2026 14:13
ben-challis
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
!=2.2.6from thephpstan/phpstandevelopment constraint.phpstan/phpstan: ^2.2andrector/rector: ^2.5.composer.lockto PHPStan 2.2.6 and Rector 2.5.8.RemoveDefaultValueFromAssignedPropertyRectorchange that Rector 2.5.8 reports intests/Support/TerminalEmulator.php.Why
Rector 2.5.7 could not start with PHPStan 2.2.6 because PHPStan removed a private parser property that Rector reads. Rector 2.5.8 contains the upstream fix. The exclusion is no longer necessary.
Upstream fix: rectorphp/rector-src#8208
Guard PR: #87
Closes #86
Checklist
composer static-analysisis greencomposer testsis green