test(phpstan): allow nullable constructor services - #1067
Merged
ben-challis merged 1 commit intoJul 30, 2026
Conversation
ben-challis
merged commit Jul 30, 2026
dd9c7c8
into
codex/fix-test-metadata-nonfinite-diagnostics
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A required nullable object parameter is still resolvable as a constructor service. Add a nullable Service to the valid PHPStan probe so the rule must remove null before checking the object type. Removing that normalization survived the previous suite and this case kills the exact mutant.