Skip to content

test(phpstan): validate named attribute arguments - #1065

Merged
ben-challis merged 1 commit into
codex/fix-test-metadata-nonfinite-diagnosticsfrom
codex/test-phpstan-named-attribute-arguments
Jul 30, 2026
Merged

test(phpstan): validate named attribute arguments#1065
ben-challis merged 1 commit into
codex/fix-test-metadata-nonfinite-diagnosticsfrom
codex/test-phpstan-named-attribute-arguments

Conversation

@ben-challis

Copy link
Copy Markdown
Owner

Named Timeout, Retry, and RequiresResource arguments must receive the same domain checks as positional arguments. Add named invalid values to the acceptance probe and pin the three additional diagnostics. Removing the named lookup branch survived the previous suite and this coverage kills that exact mutant.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ben-challis
ben-challis merged commit eaf71b7 into codex/fix-test-metadata-nonfinite-diagnostics Jul 30, 2026
16 checks passed
@ben-challis
ben-challis deleted the codex/test-phpstan-named-attribute-arguments branch July 30, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant