Skip to content

test(rector): preserve invalid TestWith labels - #1064

Merged
ben-challis merged 1 commit into
mainfrom
codex/test-rector-invalid-test-with-label
Jul 30, 2026
Merged

test(rector): preserve invalid TestWith labels#1064
ben-challis merged 1 commit into
mainfrom
codex/test-rector-invalid-test-with-label

Conversation

@ben-challis

Copy link
Copy Markdown
Owner

Pins the safe migration boundary for TestWith labels that use an unsupported named parameter. The Rector rule MUST leave the class untouched instead of silently renaming invalid input. This is distinct from #1034, which covers the first data argument; this PR covers the second label argument.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ben-challis
ben-challis changed the base branch from codex/fix-test-metadata-nonfinite-diagnostics to main July 30, 2026 11:12
@ben-challis
ben-challis merged commit 5e802e8 into main Jul 30, 2026
17 checks passed
@ben-challis
ben-challis deleted the codex/test-rector-invalid-test-with-label branch July 30, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant