test(phpstan): enforce consistently throw constraints - #1062
Merged
ben-challis merged 1 commit intoJul 30, 2026
Conversation
ben-challis
changed the base branch from
codex/fix-test-metadata-nonfinite-diagnostics
to
main
July 30, 2026 11:12
ben-challis
deleted the
codex/test-phpstan-consistently-throw-constraints
branch
July 30, 2026 13:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers toThrow() message constraints on consistently() expectations. The PHPStan rule MUST reject matching: and message: together for ConsistentlyExpectation, as it already does for immediate and eventual expectations. Removing ConsistentlyExpectation support survived the previous full suite; this coverage kills that exact mutant.