Don't orphan SplitContainer content when the assignment is invalid - #4633
Open
Dev9269 wants to merge 2 commits into
Open
Don't orphan SplitContainer content when the assignment is invalid#4633Dev9269 wants to merge 2 commits into
Dev9269 wants to merge 2 commits into
Conversation
Dev9269
force-pushed
the
fix-splitcontainer-content-setter
branch
from
August 5, 2026 22:05
6622e84 to
45ba723
Compare
freakboy3742
reviewed
Aug 6, 2026
freakboy3742
requested changes
Aug 6, 2026
freakboy3742
left a comment
Member
There was a problem hiding this comment.
Good catch - thanks for the report and PR.
However - this has clearly broken CI. I'm guessing this is because the test app lifecycle isn't being honoured because you're manually constructing the SplitContainer widget rather than using the fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SplitContainer.contentsetter detached the currently-shown widgets before validating the new value:If the assignment was invalid (wrong length, duplicate widget, wrong element type), the exception propagated but the old content had already been orphaned —
app/windowwere reset toNone, so the previously-visible widgets detached from the widget tree even thoughcontentstill reported the old value.This PR moves the detach to after the new content is fully validated, so a failed assignment leaves the current content attached and intact.
Fixes #4631
PR Checklist:
Assisted-by: Claude Opus 4.5