Fix E501 line length violations in tests/integrations/ and tests/platforms/ by phyodev · Pull Request #2979 · beeware/briefcase

phyodev · 2026-08-04T15:51:27Z

This PR is to fix E501 errors under tests/integrations and tests/platforms

Closes Resolve E501 ignored Ruff rule #2383

PR Checklist:

All new features have been tested
All new features have been documented
I will abide by the BeeWare Code of Conduct
I have read and have followed the CONTRIBUTING.md file
This PR was generated or assisted using an AI tool

Assisted-by: Gemini Plus (as Chatbot)

mhsmith · 2026-08-04T21:23:58Z

Originally posted by @phyodev in #2383

Let me continue this to cleanup E501 under tests/integrations and tests/platforms. Let me test and check code coverage after cleanup to align with the contribution guideline too

ruff check passes and that tests/integrations/ pass locally, while tests/platforms/linux/, tests/platforms/macOS and tests/platforms/conftest.py failures are due to running on Windows (symlink/privilege limitations)

I tested with this:
pre-commit run -a
ruff check tests/integrations tests/platforms --select E501
tox -e py -- tests/integrations/
tox -e py -- tests/platforms/

Note:
due to some limitations
tested on Windows 10, i7 12th Gen

freakboy3742

There's no need to tell us how you ran the test suite - you just need to run it. The tests also need to pass - and CI is currently showing problems.

A key detail in this refactor I that we need to retain readability. It's not enough to just split strings into multiple parts - the final result needs to be clear to read as well.

Consider the following:

"this is a long string"
"that runs across lines\n"
"but how many lines are there?\n"

That visually looks like 3 lines, but is actually 2. That's potentially very confusing to debug - so we need to find ways to structure the code so that ambiguity doesn't exist.

That might involve moving the test output to a standalone file, as is done in a lot of the Android/ADB integration tests.

mhsmith

There are some CI failures involving forward slash / backslash differences.

Other inline comments below:

mhsmith · 2026-08-04T21:35:27Z

+        "Intel x86_64 Atom System Image | "
+        "system-images/android-31/default/x86_64\n"


These two lines could be combined into one to maintain a consistent 2 fields per line, which would make the table readable even when wrapped.

On second thoughts, this should probably be exempted from the line length limit, as discussed below.

mhsmith · 2026-08-04T21:38:10Z

+        "-------                        | -------\n"
+        "  system-images;android-31;default;x86_64 | 5       | "
+        "Intel x86_64 Atom System Image | "
+        "system-images/android-31/default/x86_64\n"


See comment on similar code above.

phyodev · 2026-08-05T03:24:29Z

Thanks for your feedback. Let me review and fix my changes to align with your suggestions

phyodev · 2026-08-05T09:19:26Z

There are some CI failures involving forward slash / backslash differences.

Other inline comments below:

Thanks for your feedback and let me fix it

mhsmith · 2026-08-05T10:53:16Z

        ),
        (
-            "\x1b[32mD/libEGL  : loaded /vendor/lib64/egl/libEGL_emulation.so\x1b[0m",
+            ("\x1b[32mD/libEGL  : loaded /vendor/lib64/egl/libEGL_emulation.so\x1b[0m"),


Unnecessary parentheses (multiple instances in this file, and other files; I won't bother marking any more).

mhsmith · 2026-08-05T10:56:01Z

+            (
+                "test_case (tests.foobar.test_other.TestOtherMethods)",
+                True,
+            ),


Unnecessary change (multiple instances in this file).

mhsmith · 2026-08-05T10:58:00Z

+                            / (
+                                "base_path/build/first-app/android/gradle/"
+                                "app/build/python/pip/debug/common"
+                            )


Suggested change

/ (

"base_path/build/first-app/android/gradle/"

"app/build/python/pip/debug/common"

)

/ "base_path/build/first-app/android/gradle"

/ "app/build/python/pip/debug/common"

‎ There are multiple instances of this in other files; I won't bother marking any more of them.

mhsmith · 2026-08-05T11:07:14Z

+        # zip file can include a “__MACOSX” folder for
+        # each document that contains information about
        # the file useful for Finder and will not be in the unzipped set of files


Uneven line length.

mhsmith · 2026-08-05T11:10:42Z

    # As a result of mocking ditto, the zip archive won't *actually* be created;
    # and as a result of mocking os, it won't *actually* be deleted either - but we can
-    # verify that it *would* have been deleted. ditto will also be called when finalizing,
+    # verify that it *would* have been deleted.
+    # ditto will also be called when finalizing,


Uneven line length.

mhsmith · 2026-08-05T11:11:09Z

+    # Package the app without code signing.
+    # Use the base command's interface to ensure the full
    # cleanup process is tested.


Uneven line length: could probably be 2 lines if properly wrapped.

mhsmith · 2026-08-05T11:23:55Z

-        == "Ad-hoc identity. The resulting package will run but cannot be re-distributed."
+        adhoc.name == "Ad-hoc identity. The resulting package will run "
+        "but cannot be re-distributed."
    )


adhoc_name should be outside the parentheses, in which case the string might not even need to be split.

mhsmith · 2026-08-05T11:27:04Z

+                (
+                    "        0   DTDeviceKitBase                     "
+                    "0x00000001288ff298 DTDKCreateNSErrorFromAMDErrorCode + 300"
+                ),


For testing purposes, this could be reduced to only 2 stack trace entries.

mhsmith · 2026-08-05T11:29:41Z

+                    import { hooks } from "https://pyscript.net/"""
+            """releases/2024.11.1/core.js";


In this case, and all others involving HTML and CSS blocks, I think skipping the check with a noqa comment would be better.

mhsmith · 2026-08-05T15:32:22Z

Please don't mark conversations as resolved: let the person who started the conversation do that. Automatic resolution from accepting a suggestion is OK.

mhsmith · 2026-08-05T15:39:12Z

Consider the following:
"this is a long string"
"that runs across lines\n"
"but how many lines are there?\n"
That visually looks like 3 lines, but is actually 2. That's potentially very confusing to debug - so we need to find ways to structure the code so that ambiguity doesn't exist.

For multi-line strings, especially if they're structured as a table or something, maybe the best solution would be to keep it as a triple-quoted string with dedent, and exempt it from the line length check. Adding a noqa comment after the closing parenthesis would hopefully be sufficient.

phyodev · 2026-08-12T04:03:25Z

Consider the following:
"this is a long string"
"that runs across lines\n"
"but how many lines are there?\n"
That visually looks like 3 lines, but is actually 2. That's potentially very confusing to debug - so we need to find ways to structure the code so that ambiguity doesn't exist.
For multi-line strings, especially if they're structured as a table or something, maybe the best solution would be to keep it as a triple-quoted string with dedent, and exempt it from the line length check. Adding a noqa comment after the closing parenthesis would hopefully be sufficient.

@mhsmith Hey! I updated my changes according to your feedbacks. But I am not still merge main to my branch yet because there is some CI failures. But I believe my codes are aligned accordingly. If further more needed feel free to tell me

phyodev added 7 commits August 2, 2026 22:55

fix: to avoid E501 error in files under tests/integrations

5001975

fix: to avoid E501 error in files under tests/platforms

899452c

Merge branch 'main' into fix-e501-tests-itg-plf

c2ec904

fix: tests/integrations test_VisualStudio__verify wrong formatting

efc4b30

Merge branch 'main' into fix-e501-tests-itg-plf

2ab0dfa

feat: Add change note for issue beeware#2383

685c96e

fix: pre-commit formatting failures

cd6af7b

mhsmith mentioned this pull request Aug 4, 2026

Resolve E501 ignored Ruff rule #2383

Open

freakboy3742 requested changes Aug 4, 2026

View reviewed changes

Comment thread pyproject.toml Outdated

mhsmith reviewed Aug 4, 2026

View reviewed changes

fix: formatting errors [E501]mhsmith feedbacks

2c67cd6

phyodev added 4 commits August 5, 2026 13:32

fix: plf\linux\system\test_run.py CI fail

c1e2307

fix: remove E501 linting ignores

c358722

fix: argument missing error / CI Fails

3101fea

fix: reformating/ CI Fails

69f58c1

phyodev requested a review from freakboy3742 August 5, 2026 09:25

mhsmith reviewed Aug 5, 2026

View reviewed changes

fix: beeware#2 wrong formatting

cabebb8

phyodev force-pushed the fix-e501-tests-itg-plf branch 2 times, most recently from cb9f792 to cabebb8 Compare August 12, 2026 03:53

Merge branch 'main' into fix-e501-tests-itg-plf

5b58fb4

phyodev requested a review from mhsmith August 12, 2026 03:59

		"Intel x86_64 Atom System Image \| "
		"system-images/android-31/default/x86_64\n"

		import { hooks } from "https://pyscript.net/"""
		"""releases/2024.11.1/core.js";

Uh oh!

Uh oh!

Conversation

phyodev commented Aug 4, 2026 • edited by mhsmith Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist:

Uh oh!

mhsmith commented Aug 4, 2026

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mhsmith left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phyodev commented Aug 5, 2026 • edited by mhsmith Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phyodev commented Aug 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhsmith commented Aug 5, 2026

Uh oh!

mhsmith commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phyodev commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

phyodev commented Aug 4, 2026 •

edited by mhsmith

Loading

mhsmith left a comment •

edited

Loading

phyodev commented Aug 5, 2026 •

edited by mhsmith

Loading

mhsmith commented Aug 5, 2026 •

edited

Loading