-
-
Notifications
You must be signed in to change notification settings - Fork 537
Use isolated virtual environments for app builds. #2967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a0995f1
Use isolated virtual environments for app builds.
freakboy3742 041c227
Add changenote.
freakboy3742 0b025f5
Remove some unnecessary test changes.
freakboy3742 f69c78f
Remove macOS stub binary changes.
freakboy3742 9f3b501
Use pip from the briefcase environment.
freakboy3742 d9b140e
Make docker references to sys.executable explicit.
freakboy3742 bc1eb43
Make binary package installs a consistent default.
freakboy3742 bd3e21b
Merge remote-tracking branch 'upstream/main' into app-envs
freakboy3742 43b9f47
Correct tests around requiring binaries.
freakboy3742 ba15a1e
Add another reason why binaries are required.
freakboy3742 61eeafb
Add changenote about binary requirement for wheels.
freakboy3742 dc871a3
Bump .github workflow hash to disable OpenSUSE.
freakboy3742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Apps now use an isolated environment when installing requirements. This removes a source of error where the environment running Briefcase could have an impact the packages installed into a standalone app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Windows apps now enforce the use of binary artefacts when installing Python dependencies. If you have a dependency that is only available as a source tarball, ask the upstream maintainer to publish a wheel on PyPI; alternatively, you can build a wheel locally (using `pip wheel`), and then add the directory that contains the wheel to your requirements using `requirement_installer_args`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest changing this example to use
requirement_installer_args, and moving it to that option's section, because it doesn't currently have any examples except for those involving path transformation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed this example needs to be updated; I was planning to tweak these docs as part of the
uvupdate (since that's the point whererequiresstrictly stops being a "you can pass in any installer arg" option.