-
-
Notifications
You must be signed in to change notification settings - Fork 535
Bump docformatter from v1.7.7 to v1.7.8 #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| The `pre-commit` hook for `docformatter` was updated to its latest version. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,12 +13,10 @@ def main(): | |
| """ | ||
|
|
||
| def app_start_source(self): | ||
| return """\ | ||
| from {{ cookiecutter.module_name }}.app import main | ||
| return r"""\ from {{ cookiecutter.module_name }}.app import main. | ||
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
| """ | ||
| if __name__ == "__main__": main() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question as previous. I'm seeing this a lot, so I won't continue to point them out. |
||
| """ | ||
|
|
||
| def pyproject_table_briefcase_app_extra_content(self): | ||
| return """ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,8 +79,8 @@ def full_options(state, options): | |
|
|
||
| :param state: The current command state. Can be ``None``. | ||
| :param options: The base options. | ||
| :returns: A dictionary containing all of ``options``, with any values | ||
| provided in ``state`` overriding the base ``options`` values. | ||
| :returns: A dictionary containing all of ``options``, with any values provided in | ||
| ``state`` overriding the base ``options`` values. | ||
| """ | ||
| if state is not None: | ||
| full = options.copy() | ||
|
|
@@ -446,7 +446,6 @@ def unbuilt_executable_path(self, app) -> Path: | |
|
|
||
| :param app: The app config | ||
| """ | ||
|
|
||
| if sys.platform == "win32": # pragma: no-cover-if-not-windows | ||
| suffix = self.binary_executable_path(app).suffix | ||
| else: # pragma: no-cover-if-is-windows | ||
|
|
@@ -691,8 +690,8 @@ def finalize_app_config(self, app: DraftAppConfig, **kwargs) -> FinalizedAppConf | |
| configuration, and performs any other app-specific platform configuration and | ||
| verification that is required as a result of command-line arguments. | ||
|
|
||
| Platform overrides should call ``super().finalize_app_config(app, **kwargs)`` | ||
| to construct the ``FinalizedAppConfig``. | ||
| Platform overrides should call ``super().finalize_app_config(app, **kwargs)`` to | ||
| construct the ``FinalizedAppConfig``. | ||
|
|
||
| :param app: The app configuration to finalize. | ||
| :param kwargs: Runtime attributes forwarded to the FinalizedAppConfig | ||
|
|
@@ -812,7 +811,6 @@ def verify_app_template(self, app: FinalizedAppConfig): | |
|
|
||
| :param app: app configuration | ||
| """ | ||
|
|
||
| # Skip this check if the template isn't rolled out | ||
| # or if the command doesn't support templates | ||
| try: | ||
|
|
@@ -841,7 +839,6 @@ def verify_app_template(self, app: FinalizedAppConfig): | |
| def verify_required_python(self, app: FinalizedAppConfig): | ||
| """Verify that the running version of Python meets the project's | ||
| specifications.""" | ||
|
|
||
| requires_python = getattr(self.global_config, "requires_python", None) | ||
| if not requires_python: | ||
| return | ||
|
|
@@ -1149,8 +1146,8 @@ def update_cookiecutter_cache(self, template: str, branch="master"): | |
|
|
||
| :param template: The template URL or path. | ||
| :param branch: The template branch to use. Default: ``master`` | ||
| :return: The path to the cached template. This may be the originally | ||
| provided path if the template was a file path. | ||
| :return: The path to the cached template. This may be the originally provided | ||
| path if the template was a file path. | ||
| """ | ||
| if is_repo_url(template): | ||
| # The app template is a repository URL. | ||
|
|
@@ -1235,17 +1232,17 @@ def update_cookiecutter_cache(self, template: str, branch="master"): | |
| # warn the user that the template may be stale. | ||
| self.console.debug(str(e)) | ||
| self.console.warning( | ||
| """ | ||
| ************************************************************************* | ||
| ** WARNING: Unable to update template ** | ||
| ************************************************************************* | ||
| """************************************************************* | ||
| ************ ** WARNING: Unable to update template | ||
| ** ************************************************************* | ||
| ************ | ||
|
|
||
| Briefcase is unable the update the application template. This | ||
| may be because your computer is currently offline. Briefcase will | ||
| use existing template without updating. | ||
| Briefcase is unable the update the application template. This | ||
| may be because your computer is currently offline. Briefcase will | ||
| use existing template without updating. | ||
|
|
||
| ************************************************************************* | ||
| """ | ||
| ************************************************************************* | ||
| """ | ||
|
Comment on lines
+1235
to
+1245
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems odd to me. Maybe it's not. |
||
| ) | ||
|
|
||
| try: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -722,12 +722,10 @@ def convert_app( | |
| prefix=context["app_name"], | ||
| ) | ||
| self.console.info( | ||
| """ | ||
| To run your application, type: | ||
|
|
||
| $ briefcase dev | ||
| """To run your application, type: | ||
|
|
||
| """ | ||
| $ briefcase dev | ||
| """ | ||
|
Comment on lines
-726
to
+728
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wouldn't this be wrong in the docs without dedenting? |
||
| ) | ||
|
|
||
| def validate_pyproject_file(self) -> None: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this valid without the newline?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's valid Python, but it's certainly not recommended. In fact, none of the changes to this string are improvements.
Docformatter shouldn't be editing triple-quoted strings unless they are actually docstrings. This seems to be the issue behind almost all of your comments.