convert: skip missing album art instead of crashing#6749
Open
cycsmail wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6749 +/- ##
==========================================
+ Coverage 74.52% 74.57% +0.05%
==========================================
Files 162 162
Lines 20818 20821 +3
Branches 3295 3296 +1
==========================================
+ Hits 15515 15528 +13
+ Misses 4547 4536 -11
- Partials 756 757 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4692.
convert -awithcopy_album_artenabled crashes with aFileNotFoundErrorwhen the album's stored art path points at a file that no longer exists on disk (for example a multi-disc album whose cover lives in the album root rather than in each per-disc directory). This adds anos.path.isfileguard incopy_album_artso a missing source is logged and skipped instead of aborting the conversion, using the sameutil.syspathconvention already used for the destination check just below.To Do
Documentation.(No new flags or behaviour to document.)test_copy_album_art_missing_source, which reproduces the crash without this change and passes with it.)