fix(ftintitle): parenthetical features#6716
Open
treyturner wants to merge 1 commit into
Open
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6716 +/- ##
=======================================
Coverage 74.60% 74.61%
=======================================
Files 163 163
Lines 20830 20852 +22
Branches 3283 3289 +6
=======================================
+ Hits 15541 15559 +18
- Misses 4538 4540 +2
- Partials 751 753 +2
🚀 New features to boost your workflow:
|
8b03a62 to
f90d80b
Compare
snejus
reviewed
Jun 12, 2026
0806299 to
6f02b6d
Compare
6f02b6d to
c1de81d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6715:
ftintitlehandling for featured artists wrapped in parentheses or square brackets.Before this change, parenthetical features were split at the feature token but the surrounding delimiters were left behind on both sides. For example:
became:
With this PR, we get the intended:
The same cleanup applies to square brackets, e.g.
Alice [ft. Bob].Details
()or[]pair when it encloses the feature marker split.Alice ft. (Bob)still extracts(Bob).Alice [ft. Bob]on Bob’s album extractsAlice.Tests
ftintitlecases for:find_feat_partalbum-artist behaviorsplit_on_featdelimiter cleanup and non-cleanup boundariesTo Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)