Fix tests failing with --prefer-lowest#375
Conversation
Add koriym/php-server to require-dev (not pulled by bear/devtools 1.0.2) Pin webmozart/assert ^2.0 to avoid PHP 8.4 deprecation in 1.x
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
Changes開発依存関係
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #375 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 687 687
===========================================
Files 96 96
Lines 1720 1720
===========================================
Hits 1720 1720 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Problem
composer update --prefer-lowest+composer testproduced 2 errors and 1 deprecation:Koriym\PhpServer\PhpServernot found —bear/devtools1.0.2 (the lowest version) does not depend onkoriym/php-server, but tests use it directly.webmozart/assert1.x usesarray('static', )which is deprecated in PHP 8.4.Fix
koriym/php-server: ^1.0torequire-devwebmozart/assert: ^2.0inrequire-dev(compatible withphpdocumentor/reflection-docblock's^1.9.1 || ^2constraint)Verification
composer update --prefer-lowest --prefer-stable+composer test— 403 tests, 0 errors, 0 deprecationscomposer update+composer test— 403 tests, 0 errors, 0 deprecationscomposer cs-fix— no violations