Throw EmbedException when a _self-embedded resource returns no body

[koriym]

Summary

A resource embedded as _self has its body flattened into the parent by EmbedInterceptor::linkSelf, which reads $result->body. But #[CacheableResponse] / #[DonutCache] restore only the view on a cache hit, not the body. So a _self-embedded resource with those cache attributes breaks silently on the second (cache-hit) request:

• dev: dies on assert(is_array($result->body)) with no explanation
• prod: does an empty foreach(null) merge (a warning, then a blank body)

This PR replaces the assert with a domain exception whose message names the fix, turning a confusing failure into a fail-fast with actionable guidance:

"_self" embed of {uri} returned no body. #[CacheableResponse]/#[DonutCache] restore only the view on a cache hit, not the body; a resource embedded as "_self" must use #[Cacheable] (value cache).

Test

Added testSelfLinkNullBodyThrowsEmbedException. Independently verified that reverting the guard back to the old assert makes the test fail — confirming the test truly depends on the new behavior rather than passing incidentally. Full suite green: 404 tests, 704 assertions.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 26a711c7-16d2-4d2d-abd2-8315546bcffc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f708627) to head (0e0e0a0).

Additional details and impacted files

@@             Coverage Diff             @@
##                 1.x      #374   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       687       688    +1     
===========================================
  Files             96        96           
  Lines           1722      1726    +4     
===========================================
+ Hits            1722      1726    +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[koriym]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.