KICK-302 Moodle 5.x compatibility (5.0–5.2), drop 4.x - #83
Open
stefanscholz wants to merge 2 commits into
Open
Conversation
- version.php: require Moodle 5.0 (2025041400), supported [500, 502] - CI: test against MOODLE_500/501/502_STABLE (PHP 8.2 for 5.0, 8.3 for 5.1/5.2 since 5.2 requires PHP 8.3+); drop the 4.05 matrix entries - Remove now-dead 4.x Bootstrap 4 data-attribute fallbacks; Moodle 5.x is always Bootstrap 5, so emit data-bs-* directly Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Task linked: KICK-302 Moodle 5.2 compatibility |
core/modal_factory was removed in Moodle 5.2, so the formatkickstart AMD module failed to load (breaking the tertiary navigation and all Behat scenarios on 5.2). Migrate to core/modal_save_cancel, which exists across 5.0–5.2, and rebuild the compiled AMD. Bump the release name to 1.6. Verified on a Moodle 5.2 site: the previously failing Behat scenarios pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
format_kickstartcompatible with the Moodle 5.x series (5.0, 5.1, 5.2) and drops 4.x support.requiresraised to Moodle 5.0 (2025041400);supportedset to[500, 502]; plugin version bumped.MOODLE_500_STABLE/MOODLE_501_STABLE/MOODLE_502_STABLEon both MariaDB and PostgreSQL. PHP 8.2 for 5.0; PHP 8.3 for 5.1/5.2 (Moodle 5.2 requires PHP 8.3+). The 4.05 entries are removed.data-*attribute fallbacks ($CFG->branch >= 500was always true); Moodle 5.x is Bootstrap 5, so the renderers emitdata-bs-*directly.Verification
php -land the Moodle code checker (moodlehq/moodle-cs,--standard=moodle) pass on all changed files; both CI YAMLs validate. The full plugin CI (PHPUnit + Behat across the 5.0/5.1/5.2 matrix) runs on this PR.