Add filter collection extension callback and forced conditions - DASH-1285 - #133
Merged
Conversation
…-1285 Adds the dash_augment_filter_collection plugin callback so other plugins can inject filters/conditions into any data source, and the forced_condition_interface marker so injected conditions survive the preference based filter removal. Foundation for the Workplace tenant scoping addons.
Moodle Code Checker runs with --max-warnings 0, so the four test methods missing coverage information failed the build. A class level @Covers on the data source under test satisfies all of them. Also drop the blank line after the class opening brace and add the space after the anonymous class keyword, both flagged as errors by the same run.
A branch with an open pull request triggered both the push and the pull_request workflow, running the whole matrix twice for one commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the dash_augment_filter_collection plugin callback so other plugins can inject filters/conditions into any data source, and the forced_condition_interface marker so injected conditions survive the preference based filter removal. Foundation for the Workplace tenant scoping addons.