Merged
Conversation
Owner
|
Thanks @TheSkyentist , I'm not overly concerned with supporting Python < 3.9. It's probably about time for a new release anyway. Merging now. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg_resources is deprecated and will be removed in future versions of Python 3.12 and 3.13 (and onward).
I have updated the code to use the recommended importlib implementation.
However, this has the side effect of requiring a minimum Python version of 3.9 for sedpy.
I defer to the maintainer to decide the best way forward, but this would still leave sedpy v4.0 compatible with older versions of Python, but require future versions of sedpy be on Python versions which are not EOL.