refactor: CCP-5193 reduce user search code - #662
Open
WalterMoar wants to merge 4 commits into
Open
Conversation
WalterMoar
force-pushed
the
refactor/5193-user-search-dupe
branch
from
August 27, 2026 16:01
0907ad7 to
621270e
Compare
WalterMoar
force-pushed
the
refactor/5193-user-search-dupe
branch
from
August 27, 2026 16:50
621270e to
4304ef9
Compare
Rename to useUserSearchStore, as it's not about the current user (that's the auth store)
WalterMoar
force-pushed
the
refactor/5193-user-search-dupe
branch
from
August 27, 2026 17:22
4304ef9 to
3cb8b6c
Compare
WalterMoar
force-pushed
the
refactor/5193-user-search-dupe
branch
from
August 27, 2026 18:42
55d0c37 to
ed5c54d
Compare
Simplify the user search, starting with the user search store and including dependencies and dependents.
WalterMoar
force-pushed
the
refactor/5193-user-search-dupe
branch
from
August 27, 2026 18:48
ed5c54d to
ad85a04
Compare
Add text in the table empty state to say that the search is underway.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The work for
CCP-4940: CSTAR - Fix disabled menu item so that it isn't clickablecaused Sonar to identify duplicate code. Recommend that the combined IDIR/BCeID search logic be moved to a single location (user store?) to prevent duplicate code.Acceptance Criteria
useUserStoretouseUserSearchStoreType of change
refactor: a code change that neither fixes a bug nor adds a featureChecklist
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: