Skip to content

refactor: CCP-5193 reduce user search code - #662

Open
WalterMoar wants to merge 4 commits into
mainfrom
refactor/5193-user-search-dupe
Open

refactor: CCP-5193 reduce user search code#662
WalterMoar wants to merge 4 commits into
mainfrom
refactor/5193-user-search-dupe

Conversation

@WalterMoar

@WalterMoar WalterMoar commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

The work for CCP-4940: CSTAR - Fix disabled menu item so that it isn't clickable caused Sonar to identify duplicate code. Recommend that the combined IDIR/BCeID search logic be moved to a single location (user store?) to prevent duplicate code.

Acceptance Criteria

  • Maybe rename useUserStore to useUserSearchStore
  • Tenant User and Group Member search logic for users only exists in one place
  • Simplify the store and service to use a single search(type, value) method

Type of change

refactor: a code change that neither fixes a bug nor adds a feature

Checklist

  • I have performed a thorough self-review of the changes in this PR
  • The changes are self-explanatory or have comments where needed
  • I have checked that documentation is still accurate after these changes
  • My changes are covered by the existing tests or tests have been added

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@WalterMoar
WalterMoar force-pushed the refactor/5193-user-search-dupe branch from 0907ad7 to 621270e Compare August 27, 2026 16:01
@WalterMoar
WalterMoar force-pushed the refactor/5193-user-search-dupe branch from 621270e to 4304ef9 Compare August 27, 2026 16:50
Rename to useUserSearchStore, as it's not about the current user (that's the auth store)
Simplify the user search, starting with the user search store and including dependencies and dependents.
Add text in the table empty state to say that the search is underway.
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant