Release: promote Solr changes to main for TEST deployment#1982
Closed
Oluwapizzy wants to merge 28 commits into
Closed
Release: promote Solr changes to main for TEST deployment#1982Oluwapizzy wants to merge 28 commits into
Oluwapizzy wants to merge 28 commits into
Conversation
* part 1 * fill out vaults
* #29879 namex solr api integration * fix lint error * fix lint error * fix lint error * remove test related to phonetic
* fix lint error * fix lint error * cerate solr-client * remove useless code * fix lint error * fix CI unit-testing error * revert
* Remove punctuation from names before extracting phonetics * query synonyms and extract hilight words in query results * fix lint error
* Add designation from NameRequestto support Solr name filter * fix lint error
* Update according to new Solr-API highlighting output * Lint error fix
Feature solr merged
* 31219-Update cloudrun name. (#1948) * 31278-Update code owners. (#1949) * 30941 - fix - Add dataclass-based dynamic attribute initialization (#1944) * fix - Add dataclass-based dynamic attribute initialization * test - Add unit tests for `PaymentToken` and `ReceiptResponse` dataclasses and refactor initialization logic * refactor - Replace `from_dict` methods with Pydantic-based dataclass initialization across `PaymentToken` and `ReceiptResponse` for consistent and simplified validation * test - Add unit tests for `PaymentInvoice` dataclass and refactor to use Pydantic initialization * refactor - Update `links` field in Pydantic model to use alias "_links" for consistency * test/refactor - Add `invoice` field support in `ReceiptResponse` with tests and update `links` alias logic * refactor/tests - Update DB connection logic for tests, add refund field, and improve type handling in tests * test - Enhance `PaymentInvoice` tests to validate numeric types and use `pytest.approx` for floating-point assertions * test/refactor - Replace hardcoded assertions in `test_payment_invoice` with dynamic checks using `data` dictionary * test - Add `PaymentRefundInvoice` dataclass, update `refund_payment` logic, and add unit tests * perf: configure container concurrency to 20 and max scale to 60 for namex services. * 32058-Email link fix for create account (#1954) * 32058-Update "create account" url for email templates. * Update create account links. * 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32438-Add John Andrews to Reports Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32438-Add John Andrews to Reports Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32438-Add John Andrews to Reports Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239 Fix Bad Designation Norifier CI and add John Andrews to Reports * feat: Add Solr document converters for NR and CORP formats - Introduced `convert_solr_doc` for transforming Solr add documents. - Added `_convert_nr_doc` and `_convert_corp_doc` for handling NR and CORP sources. - Implemented `_extract_date` utility for ISO datetime parsing. - Updated `poetry.lock` with dependency upgrades. --------- Co-authored-by: mengdong19 <meng.dong@gov.bc.ca> Co-authored-by: pwei1018 <patrick.wei@gov.bc.ca> Co-authored-by: Patrick Wei <44277752+pwei1018@users.noreply.github.com> Co-authored-by: Chen <Steven.Chen@gov.bc.ca>
* 31219-Update cloudrun name. (#1948) * 31278-Update code owners. (#1949) * 30941 - fix - Add dataclass-based dynamic attribute initialization (#1944) * fix - Add dataclass-based dynamic attribute initialization * test - Add unit tests for `PaymentToken` and `ReceiptResponse` dataclasses and refactor initialization logic * refactor - Replace `from_dict` methods with Pydantic-based dataclass initialization across `PaymentToken` and `ReceiptResponse` for consistent and simplified validation * test - Add unit tests for `PaymentInvoice` dataclass and refactor to use Pydantic initialization * refactor - Update `links` field in Pydantic model to use alias "_links" for consistency * test/refactor - Add `invoice` field support in `ReceiptResponse` with tests and update `links` alias logic * refactor/tests - Update DB connection logic for tests, add refund field, and improve type handling in tests * test - Enhance `PaymentInvoice` tests to validate numeric types and use `pytest.approx` for floating-point assertions * test/refactor - Replace hardcoded assertions in `test_payment_invoice` with dynamic checks using `data` dictionary * test - Add `PaymentRefundInvoice` dataclass, update `refund_payment` logic, and add unit tests * perf: configure container concurrency to 20 and max scale to 60 for namex services. * 32058-Email link fix for create account (#1954) * 32058-Update "create account" url for email templates. * Update create account links. * 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32438-Add John Andrews to Reports Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32438-Add John Andrews to Reports Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32438-Add John Andrews to Reports Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239 Fix Bad Designation Norifier CI and add John Andrews to Reports * feat: Add Solr document converters for NR and CORP formats - Introduced `convert_solr_doc` for transforming Solr add documents. - Added `_convert_nr_doc` and `_convert_corp_doc` for handling NR and CORP sources. - Implemented `_extract_date` utility for ISO datetime parsing. - Updated `poetry.lock` with dependency upgrades. * refactor: Simplify `get_possible_conflicts` by removing unnecessary name preprocessing step --------- Co-authored-by: mengdong19 <meng.dong@gov.bc.ca> Co-authored-by: pwei1018 <patrick.wei@gov.bc.ca> Co-authored-by: Patrick Wei <44277752+pwei1018@users.noreply.github.com> Co-authored-by: Chen <Steven.Chen@gov.bc.ca>
* catchup with main branch * `feat: Enhance name request search to include NR-based and name-based suggestions`
add tests, missing function
fix:use correct service account env vars for solr api auth
The new Solr does not support deleting documents. Previously, when an NR moved to a terminal state (CANCELLED, EXPIRED, CONSUMED, RESET) a delete was sent to the possible.conflicts core, which the new Solr feeder cannot process - leaving the record stale (e.g. still APPROVED) and incorrectly surfaced as a conflict. Instead of deleting, send a state update carrying the NR current state so the conflict search filters the record out (only ACTIVE/APPROVED/CONDITION are returned). Updated the related unit test to assert the new behaviour.
fix: convert possible conflict solr deletes to state updates
…707) Adds PATCH /api/v1/namerequests/<nr_id>/test-state allowing API partners to force a name request to APPROVED or REJECTED in non-production environments without publishing a names state-change event - so the change is never propagated to Solr. - New TestNameRequestState resource in the name_requests namespace (@jwt.requires_auth); deliberately omits send_name_request_state_msg so the update does not reach the Solr conflict index. - APPROVED approves the first name choice and rejects alternatives; REJECTED rejects all names (mirrors a real decision). - Guarded by ALLOW_TEST_ENDPOINT config flag (defaults false); returns 404 when not enabled - production never sets the flag. - Wires ALLOW_TEST_ENDPOINT via vaults.gcp.env per environment. - Adds endpoint tests: state update with no queue publish, invalid-state 400, and disabled-returns-404.
(#32707)feat: add test-only endpoint to set NR state without Solr update
fix secrets in .env.sample
Oluwapizzy
requested review from
mengdong19,
ozamani9gh and
stevenc987
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9442085 | Triggered | Generic Password | 2e56899 | api/.env.sample | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
stevenc987
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR promotes the Solr changes from feature-solr-merged into main as part of the planned Solr release to TEST.
Release Context
*Source branch: feature-solr-merged
*Target branch: main
*Target environment: TEST
*Release scope: Multi-repo Solr promotion
*Deployment workflow: Merge to main, then workflow/pipeline deploys to TEST
Validation Plan
After merge and TEST deployment, validation will include:
Confirming the deployment workflow completed
Validating known Solr search scenarios
Documenting any issues or follow-up actions
Post-Merge
Once the PR is approved/merged into main, the workflow/pipeline should deploy the changes to TEST.