33508 merge with main#4490
Open
kialj876 wants to merge 10 commits into
Open
Conversation
* Initial commit - Python 3.13, major deps, major flows passed manual testing, unit tests setup broken Signed-off-by: Kial Jinnah <kialj876@gmail.com> * interim commit - over 80% of tests passing Signed-off-by: Kial Jinnah <kialj876@gmail.com> * interim commit - fixes for meta, naics, and authorization tests Signed-off-by: Kial Jinnah <kialj876@gmail.com> * All tests passing except a couple Signed-off-by: Kial Jinnah <kialj876@gmail.com> * Fixed remaining tests Signed-off-by: Kial Jinnah <kialj876@gmail.com> * cleanup Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: lint fixes Signed-off-by: Kial Jinnah <kialj876@gmail.com> * sonar cloud reliability Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: rebase Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore lint warnings Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: update model dep for consolidation comments Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: cleanup for green CI Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: poetry lock for lxml dep update Signed-off-by: Kial Jinnah <kialj876@gmail.com> --------- Signed-off-by: Kial Jinnah <kialj876@gmail.com>
* 33245 Legal API - use common utils, reduce deprecation warnings Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: cleanup Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: cleanup Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: update lock file Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: fix typing on sonar cloud issue Signed-off-by: Kial Jinnah <kialj876@gmail.com> --------- Signed-off-by: Kial Jinnah <kialj876@gmail.com>
* 33246 Legal API - use common account Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: cleanup Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: ruff fix Signed-off-by: Kial Jinnah <kialj876@gmail.com> --------- Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
… common (bcgov#4465) * Legal API DBC use python common Signed-off-by: Lucas <lucasoneil@gmail.com> * lint Signed-off-by: Lucas <lucasoneil@gmail.com> * test Signed-off-by: Lucas <lucasoneil@gmail.com> * Update dep Signed-off-by: Lucas <lucasoneil@gmail.com> * Fix lock Signed-off-by: Lucas <lucasoneil@gmail.com> * Tests Signed-off-by: Lucas <lucasoneil@gmail.com> * Test Signed-off-by: Lucas <lucasoneil@gmail.com> --------- Signed-off-by: Lucas <lucasoneil@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Collaborator
Author
Existing duplication getting picked up due to new imports etc. |
kialj876
requested review from
argush3,
meawong,
mruff-aeq,
thorwolpert and
vysakh-menon-aot
Collaborator
Author
|
|
thorwolpert
approved these changes
Jun 15, 2026
thorwolpert
left a comment
thorwolpert
left a comment
Collaborator
There was a problem hiding this comment.
I looked through a great deal of this, it looks like you caught everything in the change for the model and typing (nice to bring that up to the latest pythonic style).
Great to see the model move being completed!
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
|
argush3
approved these changes
Jun 16, 2026
vysakh-menon-aot
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#33508
Description of changes:
Most of this has already been reviewed and the updates to make during the rebase were all minor things (typing, imports, test mock setup change, etc.).
You can also follow the commits below to make it easier to ignore what has already been reviewed. Please note that I rebased this off of main and you will see I messed it up a bit in the legal_api init which I fix later on in the commit history.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).