Skip to content

Merge pull request #400 from bcgov/dev - #420

Merged
Aman-Hundal merged 34 commits into
devfrom
master
May 13, 2025
Merged

Merge pull request #400 from bcgov/dev#420
Aman-Hundal merged 34 commits into
devfrom
master

Conversation

@abin-aot

@abin-aot abin-aot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Dev

@sonarqubecloud

sonarqubecloud Bot commented Oct 11, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@abin-aot
Merge pull request #421 from bcgov/dev-AA-ministryupdate-NOV2024
a32bc53 
#FOIMOD-3609 Ministry updates for NOV18 changes
@abin-aot
Merge pull request #422 from bcgov/dev-AA-ministryupdate-NOV2024
2101a49 
FOIMOD-3609 Receipt EAO nesting on JSON changes
@sonarqubecloud

sonarqubecloud Bot commented Nov 19, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mdesgov and others added 2 commits March 5, 2025 14:08
@mdesgov
Update ubuntu to 24.04 and install oc cli
8f161b9
@abin-aot
Merge pull request #444 from bcgov/dev
068c6ce 
#FOIMOD-3801 Keycloak upgrade and client update to public
@mdesgov
Merge pull request #442 from bcgov/master-MD-ubuntu-upgrade
438eab5 
Update ubuntu to 24.04 and install oc cli
@github-advanced-security

github-advanced-security AI commented Apr 28, 2025

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Aman-Hundal and others added 2 commits April 30, 2025 14:15
@Aman-Hundal
UX/UI Changes for tooltip
cefd50c
@Aman-Hundal
Merge pull request #450 from bcgov/test-AH-FOIMOD-3894
0e12874 
Ticket 3894: FOI REQUEST Form Updates (UX and UI updates to Tooltips)
github-advanced-security[bot]
github-advanced-security AI found potential problems May 7, 2025
View reviewed changes
Comment thread .github/workflows/api-cd.dev.yml Outdated
Comment on lines 30 to 73

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
@adamkroonbcgov
Merge pull request #453 from bcgov/revert-452-foi-3944-b-generating-i…
89d8c18 
…mage-update

Revert "FOI-3944: Generating new api image for ci/cd change"
github-advanced-security[bot]
github-advanced-security AI found potential problems May 7, 2025
View reviewed changes
Comment thread .github/workflows/api-cd.test.yml Outdated
Comment on lines 29 to 72

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
github-advanced-security[bot]
github-advanced-security AI found potential problems May 7, 2025
View reviewed changes
Comment thread .github/workflows/web-cd.test.yml Outdated
Comment on lines 29 to 77

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
@sonarqubecloud

sonarqubecloud Bot commented May 8, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Aman-Hundal
Aman-Hundal merged commit 2774e37 into dev May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@abin-aot @github-advanced-security @adamkroonbcgov @Aman-Hundal @mdesgov @nagarajaPC-AOT