feat(comments): keep Save & Review Next inside review queue (ENGAGE-235) - #313
Merged
Conversation
Save & Review Next always jumped to the next Pending comment, so staff reviewing Needs Further Review had to Save & Close and re-apply the status filter to reach each subsequent one. The button now resolves the next comment from the queue the reviewer entered, falling through to the other queue once theirs is empty and disappearing when both are. Needs Further Review is ordered by review_date, so a comment re-marked as Needs Further Review goes to the back of its own queue. The button is hidden for already approved or rejected comments. Comment listing status sort now maps status ids onto a review priority (Pending, Needs Further Review, Approved, Rejected) rather than relying on their numeric order, and takes a secondary sort on submission id so rows with equal status keep a stable order across pages. Ref ENGAGE-235
Ckoelewyn
requested review from
danieltruong,
marklise,
tolkamps1 and
tom0827
as code owners
July 27, 2026 22:04
tolkamps1
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save & Review Next always jumped to the next Pending comment, so staff reviewing Needs Further Review had to Save & Close and re-apply the status filter to reach each subsequent one.
The button now resolves the next comment from the queue the reviewer entered, falling through to the other queue once theirs is empty and disappearing when both are. Needs Further Review is ordered by review_date, so a comment re-marked as Needs Further Review goes to the back of its own queue. The button is hidden for already approved or rejected comments.
Comment listing status sort now maps status ids onto a review priority (Pending, Needs Further Review, Approved, Rejected) rather than relying on their numeric order, and takes a secondary sort on submission id so rows with equal status keep a stable order across pages.
Ref ENGAGE-235