Skip to content

Restore Configure Observations Dialog Functionality#1558

Draft
mauberti-bc wants to merge 6 commits into
devfrom
env-var-tidy
Draft

Restore Configure Observations Dialog Functionality#1558
mauberti-bc wants to merge 6 commits into
devfrom
env-var-tidy

Conversation

@mauberti-bc

@mauberti-bc mauberti-bc commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • Search field for adding environmental variables to observations
  • Search field for adding measurements to observations
  • TODO: Remove download template button from observations table

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@github-actions

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.01931% with 984 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.67%. Comparing base (21118f7) to head (4aad0d9).
⚠️ Report is 47 commits behind head on dev.

Files with missing lines Patch % Lines
...urements/search/MeasurementsSearchAutocomplete.tsx 0.00% 148 Missing ⚠️
app/src/contexts/observationsTableContext.tsx 0.00% 138 Missing ⚠️
...ironment/search/EnvironmentsSearchAutocomplete.tsx 0.00% 104 Missing ⚠️
...nents/measurements/ConfigureMeasurementColumns.tsx 0.00% 102 Missing ⚠️
...onents/environment/ConfigureEnvironmentColumns.tsx 0.00% 89 Missing ⚠️
...nts/environment/useConfigureEnvironmentColumns.tsx 0.00% 80 Missing ⚠️
...figure-columns/components/ConfigureColumnsPage.tsx 0.00% 65 Missing ⚠️
...ponents/measurements/search/MeasurementsSearch.tsx 0.00% 53 Missing ⚠️
...general/ConfigureGeneralColumnsSecondaryAction.tsx 0.00% 52 Missing ⚠️
...ts/measurements/useConfigureMeasurementColumns.tsx 0.00% 49 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1558      +/-   ##
==========================================
- Coverage   33.07%   32.67%   -0.41%     
==========================================
  Files        1033     1043      +10     
  Lines       65168    66198    +1030     
  Branches     2357     2361       +4     
==========================================
+ Hits        21553    21628      +75     
- Misses      43075    44030     +955     
  Partials      540      540              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mauberti-bc
mauberti-bc marked this pull request as ready for review June 23, 2025 19:11
@github-actions

Copy link
Copy Markdown

@mauberti-bc
mauberti-bc requested a review from LouisThedroux July 7, 2025 16:32
@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Jul 15, 2025
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
13.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@AMEIJER1

Copy link
Copy Markdown
Collaborator

Error when trying to add an observation via form with 2 subcounts.

Failed to delete quantitative measurements for survey observation Ids;

"ObservationSubcountMeasurementRepository->deleteObservationQuantitativeMeasurementRecordsForSurveyObservationIds"
"rowCount was null or undefined, expected rowCount != null"

@dylanrogowsky-oxd
dylanrogowsky-oxd force-pushed the dev branch 4 times, most recently from 9d98b27 to ca95d07 Compare September 18, 2025 22:10
@dylanrogowsky-oxd
dylanrogowsky-oxd marked this pull request as draft February 4, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready For Review PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants