Skip to content

reorganize and update showcase bundles - #204

Merged
krobinsonca merged 14 commits into
mainfrom
chore/update-showcase-bundles
Jul 22, 2026
Merged

reorganize and update showcase bundles#204
krobinsonca merged 14 commits into
mainfrom
chore/update-showcase-bundles

Conversation

@esune

@esune esune commented Jul 22, 2026

Copy link
Copy Markdown
Member

This PR reorganizes the OCA bundles related to credentials issued by the showcase application to live under a showcase folder, so that they are easily identifiable.

It also updates the bundles to use SHOWCASE as watermark and match the latest credential schemas/credential definitions created by the builder at the time of writing.

esune added 11 commits July 22, 2026 19:05
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
- Add scripts folder to PATH via remoteEnv in devcontainer.json
- Scripts can now be called directly without relative path prefixes
- Update OCABundleCreatePR.md with DevContainer examples
- Both genBundle.sh and gen_ocabundlesjson.sh can be called by name when using DevContainer

Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
…indexes

Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
@esune
esune requested a review from krobinsonca July 22, 2026 19:34

@krobinsonca krobinsonca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Thanks for tackling the showcase reorganization. The goals make sense (group showcase bundles, normalize the watermark, update to current credential identifiers). I have a few concerns that should be addressed before merge.

1. Inconsistent naming convention

The PR introduces two different conventions in one go:

  • bcgov-digital-trust/business-card-nonprod/ — uses a -nonprod suffix
  • bcgov-digital-trust/showcase/member-card/, showcase/person/, showcase/student-card/ — uses a parent showcase/ folder

The PR title says "live under a showcase folder" so the -nonprod rename looks out of place. Please pick one convention and apply it consistently. Either:

  • All four under showcase/ (matches the title): showcase/business-card/, showcase/member-card/, showcase/person/, showcase/student-card/
  • All use a suffix (matches the existing LCRB/*-showcase pattern): business-card-showcase/, member-card-showcase/, person-showcase/, student-card-showcase/

2. Duplicate mkdocs.yml nav block

mkdocs.yml now has two - OCA Bundles: blocks — the original at line 92 stays, and a new one is appended at the end with an expanded list. This will render duplicate nav entries on the GitHub Pages site. Looks like a copy-paste from hand-editing the file.

Please remove the duplicate block at the end. The original block at line 92 (with updated paths) is sufficient.

Note: gen_ocabundlesjson.sh regenerates the nav from the folder structure on every merge, so any manual edits to mkdocs.yml get clobbered. That said, the static file is what gets committed, so it needs to be right.

3. Stale identifier removals from person-showcase

The new showcase/person/README.md drops these identifiers:

  • KCxVC8GkKywjhWJnUfCmkW:3:CL:20:PersonQA (candy:test)
  • 7xjfawcnyTUcduWVysLww5:3:CL:28075:PersonSIT (candy:dev)
  • XpgeQa93eZvGSZBZef3PHn:3:CL:28075:PersonDEV (candy:dev)

If these cred defs are still in circulation in the showcase environment, dropping them will cause credentials to fall back to default rendering. Please confirm this is intentional.

4. Cross-folder image reference (minor)

showcase/person/OCABundle.json (and branding.json) still references bcgov-digital-trust/person/bc-logo.jpg — a different bundle. We flagged this same kind of cross-bundle image reference in PR #194. For consistency with that fix, please copy bc-logo.jpg into showcase/person/ and update the path locally.


Once #1 and #2 are addressed, this is good to go. The watermark normalization, devcontainer change, and updated docs are all welcome improvements.

Sign-off: Kyle Robinson (krobinsonca)

@esune

esune commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@krobinsonca will address 2 and 4.
1 requires more reorganization that will be tackled in subsequent PRs.
3 is deliberate: we want to split the non-production credentials from the showcase credentials, a follow-up PR will add the new bundle for these identifiers

esune added 3 commits July 22, 2026 19:56
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
Signed-off-by: Emiliano Suñé <2395873+esune@users.noreply.github.com>
@esune
esune requested a review from krobinsonca July 22, 2026 20:09

@krobinsonca krobinsonca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@krobinsonca
krobinsonca merged commit fe94fe0 into main Jul 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants