fix(routine): launchd schedule test fails on Linux CI (main is red)#590
Merged
Conversation
…inux CI Interval schedules pick the launchd backend only on darwin; TestInstallAndRemoveLaunchdSchedule asserted Backend == launchd without overriding osGOOS, so it installed a cron schedule on ubuntu runners and failed (main CI is red since #589). Use the existing osGOOS test seam, as TestCalendarCronUsesLaunchdOnDarwin already does. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's Test job has been red since #589:
TestInstallAndRemoveLaunchdScheduleasserts the launchd backend, but interval schedules only pick launchd on darwin — on ubuntu runners it installs a cron schedule and the assertion fails.One-line-ish fix: force
osGOOS = "darwin"through the existing test seam, exactly asTestCalendarCronUsesLaunchdOnDarwinalready does. Everything else in the test is already platform-stubbed (launchctl/crontab stubs, isolated dirs).This also un-reds the merge-result CI of every open PR (e.g. #583).
🤖 Generated with Claude Code