Repository navigation
fix(collector): ignore shutdown closed signal in stop - #459
Merged
Merged
Conversation
stop set stopping and then joined the live capture and upload loops. A turn that observed stopping threw CollectorRuntimeError.closed, and when that beat CancellationError, stop reported a producer failure. swift-unit hit this on 2026-10-08 in the replay-loss and start-loop tests. Background turns now throw CancellationError once stopping is set. stop also treats an already-thrown closed error from the joined loop or cycle as the same shutdown signal. runOnce after stop still throws closed. invalidConfiguration and reconciliationRequired still fail the join.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CollectorRuntime.stopsetstoppingand then joined the live capture and upload loops. A turn that observedstoppingthrewCollectorRuntimeError.closed. When that error won the race againstCancellationError,stopreported it as a producer failure.On 2026-10-08 this failed three
swift-unitjobs, all withcaught error: "closed", and each passed on rerun:113128319766(PR feat(web): sign in from Tailscale Serve identity headers (phase 1) #457 attempt 1):testReplayLossDuringStartKeepsRuntimeAndOtherRootsRunning_repro113147173237(PR docs: close out 2026-10-08 (Web identity sign-in merged and deployed) #458 attempt 1):testStartLoopPublishesAndStopJoinsBeforeReopen113152487959(PR docs: close out 2026-10-08 (Web identity sign-in merged and deployed) #458 attempt 2): the replay-loss test againBackground turns now throw
CancellationErroroncestoppingis set.stopalso treats an already-thrown.closedfrom the joined loop or cycle as the same shutdown signal.runOnceafter a finishedstopstill throws.closed.invalidConfigurationandreconciliationRequiredstill fail the join.Test plan
xcodebuild test -scheme EngramServiceCore -only-testing:EngramServiceCoreTests/CollectorRuntimeTests: 82 tests, 0 failures (2026-10-08, before this commit's changelog wording tweak). The new repro failed withclosedbefore the fix.swift-unitpasses without a rerun of those two tests.The untracked
.grok/workflows/engram-session-status.rhaiis not part of this change.