Skip to content

fix(mstp): conform master token and PFM transitions to Clause 9.5.6 - #2

Closed
bbartling wants to merge 1 commit into
fix/mstp-clause9-crcfrom
fix/mstp-clause956-token-pfm
Closed

fix(mstp): conform master token and PFM transitions to Clause 9.5.6#2
bbartling wants to merge 1 commit into
fix/mstp-clause9-crcfrom
fix/mstp-clause956-token-pfm

Conversation

@bbartling

Copy link
Copy Markdown
Owner

Summary

Clause 9.5.6 DONE_WITH_TOKEN / PASS_TOKEN / PFM fix stacked on fix/mstp-clause9-crc (jscott3201#464 upstream).

Root cause of Workbench/FEC drop when Rust joins as MAC 3: maintenance PFM began at NS+1 (BASRT 0) instead of scanning (TS, NS).

Tests

cargo test -p bacnet-transport --lib — regressions A–E in clause956_tests.rs.

Made with Cursor

DONE_WITH_TOKEN no longer reverse-scans from NS+1 or emits Token TS→TS.
Add done_with_token(), FindNewSuccessor via PFM after Nretry_token, and
regression tests A–E for multi-master coexistence.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 66bde4ef-3a1b-4cb3-8d4f-56774e505d0f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bbartling

Copy link
Copy Markdown
Owner Author

Consolidated on branch vibe13-mstp (CRC + USB + Clause 9.5.6). Closing to tidy the fork; not merging via stacked base.

@bbartling bbartling closed this Aug 30, 2026
@bbartling
bbartling deleted the fix/mstp-clause956-token-pfm branch August 30, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant