feat: port stardoc_with_diff_test macro#303
Open
alexeagle wants to merge 2 commits into
Open
Conversation
|
Could someone take a look at this? I'd like to update |
|
bump on this |
lalten
reviewed
Apr 3, 2026
lalten
reviewed
Apr 3, 2026
lalten
added a commit
to lalten/rules_appimage
that referenced
this pull request
Apr 3, 2026
Also switch from aspect_bazel_lib to its new name, bazel_lib. This needs a patch due to bazelbuild/stardoc#303. This is ok because stardoc is a Bzlmod only dev_dependency in rules_appimage
|
Some more changes might be needed to work with latest stardoc and place the generated output at the right location, see lalten/rules_appimage#416 |
Contributor
Author
|
I'd rather not put more work into this PR given the unlikelihood that maintainers will look at it or would be willing to merge it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature was dropped in bazel-lib 3.0 (since many rulesets can now just surface docs on registry.bazel.build rather than check them into the repo)
bazel-contrib/bazel-lib#1188
This implementation is by a few authors, starting with me: https://github.com/bazel-contrib/rules_go/commits/7ef8fb1bc91d2ea70a53fe123ea0556acb3bf87b/docs/doc_helpers.bzl
rulesets that want to continue checking in their generated markdown files will prefer to have this from the stardoc module, as that's the primary dependency this macro takes.