Fail when unsupported platforms are specified - #479
Merged
cloudhan merged 1 commit intoJun 4, 2026
Merged
Conversation
Signed-off-by: James Bartlett <james@gimletlabs.ai>
JamesMBartlett
requested review from
cloudhan,
jsharpe and
ryanleary
as code owners
June 3, 2026 06:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally set my platform tag to
linux-x86-64instead oflinux-x86_64, along withlinux-sbsa. This led to the build attempting to use aarch64 nvcc on an x86 host, because the 1 platform/version fallback would be hit, since the linux-x86-64 is an unsupported platform. This PR checks that all platforms specified are supported, avoiding the strange behaviour of using the wrong arch for the exec platform.