fix: add missing newline to xsystem error message - #51
Open
yohny1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a minor UI formatting issue where the shell prompt would append directly to the end of the error message when
xsystem()fails. This occurs because theprintfstatement insidexsystem()(insrc/utils.c) is missing a trailing newline character (\n).Changes
\nto theprintfformat string insrc/utils.cinside thexsystemfunction.How to test
Before this fix, running
pinfowith a directory argument (which triggers acaterror under the hood) would mangle the terminal output like this:After applying this fix, the shell prompt correctly moves to a new line after the error message is printed: