Use a gradual shape-type for the AudioData type alias#490
Open
jorenham wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that you're using shape-typing for numpy
ndarraytypes; awesome!One thing that could help avoid some annoying typing errors, is to use
tuple[Any, ...]instead oftupleint, ...]to represent an unknown shape type. That's becausetuple[int, ...]is only assignable totuple[int, ...]and not to e.g.tuple[int]. That's why there'stuple[Any, ...], which doesn't have this issue; it's assignable to tuple types of any length. So with this "gradual" shape-type, users no longer have to explicitlycastit to the "actual" shape type in their code (or# type: ignoreit).FWIW; recent versions of numpy (>=2.1) also use
tuple[Any, ...]as shape-type ofnumpy.typing.NDArrayfor this reason.