Skip to content

Avoid segfault when x and y aren't given#28

Open
N-R-K wants to merge 1 commit into
baskerville:masterfrom
N-R-K:fix-segfault
Open

Avoid segfault when x and y aren't given#28
N-R-K wants to merge 1 commit into
baskerville:masterfrom
N-R-K:fix-segfault

Conversation

@N-R-K

@N-R-K N-R-K commented Aug 20, 2023

Copy link
Copy Markdown

No description provided.

@N-R-K

N-R-K commented Aug 20, 2023

Copy link
Copy Markdown
Author

Also, using atoi is a bit poor since it cannot do proper error detection. So something invalid will just silently get converted to 0.

I'd recommend strtol with proper error checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@N-R-K