Repository navigation
Make an abnormal owner exit fail StatusLifecycleTest by name - #37
Merged
Merged
Conversation
The durable-leg halt test failed on one PostgreSQL leg in each of the last two CI runs with only "(no repo frame)": the runner prints every exception banner it finds and found none, the shape of a link exit from the start_link-linked pipeline owner. It did not reproduce in 200 isolated runs or 12 full live-suite runs on the dev box (16 and 4 cores). The four tests where a halt stops the owner now unlink it, keep a monitor, and assert it stops :normal within 15s (the durable leg's 5s budget plus margin), following StartLinkTest's 1.6.1 precedent. A real abnormal exit still fails, now at a named assertion with its reason. Verification: the file passes 12 of 12; with the owner's pipeline-DOWN stop mutated to :boom, the test fails "pipeline owner exited abnormally: :boom" at status_lifecycle_test.exs:177; mutation restored.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The durable-leg halt test died framelessly (link exit, "(no repo frame)") on one PG leg in each of the last two CI runs; it did not reproduce in 200 isolated or 12 full-suite runs on the dev box. The four halt tests now unlink the owner, monitor it, and assert a :normal stop within 15s (StartLinkTest 1.6.1 precedent), so a real abnormal exit fails at a named assertion with its reason. Red-proven with the owner stopping :boom. Test and CHANGELOG only.