Repository navigation
Install the Ash SQL helpers in the test database from committed codegen - #23
Merged
Merged
Conversation
The test repo declares installed_extensions ["ash-functions"], but the suite never installed them: the test database had no ash_* functions, while every consumer's repo installs them through its own codegen, and mix ash.codegen --check reported two pending files nothing ran. AshPostgres 2.15 emits ash_required/2 in generated SQL, so a path that needs the helpers would fail for consumers yet pass here. The generated extension migration and snapshot are committed under test/support/priv (outside the Hex package); config/test.exs points the test repo there, and test_helper.exs runs the migration in :auto mode before the per-test sandbox. CI's release-checks job now runs mix ash.codegen --check so the output stays current with the lock. Verification: the test database now has 8 ash_* functions and one recorded migration (it had 0); the five catalog-inspecting test files pass 48 tests; mix ash.codegen --check reports nothing pending.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test repo declared ash-functions but the suite never installed them (0 ash_* functions in the test database), and mix ash.codegen --check had 2 pending files. This commits the generated extension migration and snapshot under test/support/priv (outside the package), runs it in test_helper, and adds mix ash.codegen --check to release-checks. Test harness and CI only; no library code changes.