Repository navigation
Read the Oban job id without a struct pattern so consumers type-check (2.0.4) - #26
Merged
Merged
Conversation
…check (2.0.4)
Oban returns an unsaved job with id nil on a uniqueness conflict, which
is what the durable-insert retry and the not-persisted refusal handle,
but Oban.Job.t() declares id as pos_integer(). The guards injected by
use AshHooks.Worker matched %Oban.Job{id: nil}, so Dialyzer in every
consumer reported both as unreachable. They now read the id through a
private helper with identical outcomes. The Dialyzer gate covers a
consumer worker compiled from test/support (2 warnings before, 0
after), and real Oban tests on PostgreSQL cover the conflict retry and
the refusal after twenty retries. Ash moves to 3.34.6 and ash_postgres
to 2.14.5 for the currency gate.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers using
use AshHooks.Workergot two Dialyzerpattern_matchwarnings because Oban.Job.t() omits the unsaved uniqueness-conflict case (id nil). The guards now read the id through a helper; outcomes are unchanged. Dialyzer on a compiled consumer worker: 2 warnings before, 0 after. Local gates: format, compile --warnings-as-errors, credo --strict, hex.audit, currency, SQLite 787 passed, PostgreSQL 825 passed at 100.00% coverage, no-optional-deps 755 passed, exact Ash floor, consumer verify, docs, package check.