Skip to content

Fix headless bar widget test skip#6338

Open
almondsun wants to merge 1 commit into
basecamp:quattrofrom
almondsun:agent/fix-headless-bar-widget-skip
Open

Fix headless bar widget test skip#6338
almondsun wants to merge 1 commit into
basecamp:quattrofrom
almondsun:agent/fix-headless-bar-widget-skip

Conversation

@almondsun

Copy link
Copy Markdown

Summary

  • make optional temporary-directory cleanup a successful no-op when the directory was never created
  • preserve successful exit status for the headless bar widget contract skip
  • allow the aggregate shell suite to continue past that skip

Fixes #6337.

Root cause

The EXIT trap returned the status of a final [[ ... ]] && rm ... expression. On the early headless skip path, TMPDIR is unset, so cleanup returned 1 and overrode the explicit exit 0.

Validation

Passed:

  • env -u WAYLAND_DISPLAY bash test/shell.d/bar-widget-contract-test.sh
  • bash -n test/shell.d/bar-widget-contract-test.sh
  • git diff --check
  • ./test/cli (as part of ./test/all)

Aggregate limitation:

  • ./test/shell and ./test/all both continue beyond the repaired test, then stop at the unrelated existing bin-style-test.sh check because bin/omarchy-display-text-size uses raw command -v calls. This file is unchanged by the PR.

🤖 Implemented with Codex. I reviewed the change and ran the checks listed above.

@almondsun
almondsun marked this pull request as ready for review July 21, 2026 18:27
Copilot AI review requested due to automatic review settings July 21, 2026 18:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Headless bar widget contract skip exits with status 1

2 participants