Implement lid detection for fingerprint authentication#4630
Closed
c4software wants to merge 1 commit into
Closed
Conversation
Added lid detection to disable fingerprint authentication when the lid is closed. Updated PAM configuration for sudo and polkit to include the lid check.
Contributor
Author
|
Hey @dhh, I know this PR is a bit old now, but it's still relevant, and I've been testing it ever since without any issues. |
Member
|
I don't love munging these core config files to turn things off and on conditionally. I agree it would be nice to have, but either we have to find some simpler way to do it or we should make it a manual toggle, like we have with the touchpad, touchscreen etc. |
Member
|
Closing in favor of the newer clamshell fingerprint-auth implementation in #6003. |
Contributor
Author
|
Looks like the same approach and the same kind of script (with a return code). No problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Simple MR to implement the nicely done lid detection describe here #856 (comment)
This PR Add lid detection to disable fingerprint authentication when the lid is closed. Updated PAM configuration for sudo and polkit to include the lid check.