Fix: Allow passing flags/arguments to omarchy-launch-or-focus-webapp script#1980
Merged
Merged
Conversation
…-or-focus-webapp script This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp. The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function. Closes basecamp#1977
Contributor
|
#1266 - and this seem to be solving similar problems. |
dhcrzf
pushed a commit
to dhcrzf/omarchy
that referenced
this pull request
Oct 21, 2025
…-or-focus-webapp script (basecamp#1980) This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp. The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function. Closes basecamp#1977
zachasme
pushed a commit
to zachasme/omarchy
that referenced
this pull request
Oct 27, 2025
…-or-focus-webapp script (basecamp#1980) This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp. The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function. Closes basecamp#1977
guirossibrum
pushed a commit
to guirossibrum/ArchGui
that referenced
this pull request
Oct 30, 2025
…-or-focus-webapp script (basecamp#1980) This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp. The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function. Closes basecamp#1977
Contributor
|
I had to change the implementation like so for it to work well for me, without it, the -or-focus variant would not work correctly.. |
malik-na
pushed a commit
to malik-na/omarchy-mac
that referenced
this pull request
Nov 1, 2025
…-or-focus-webapp script (basecamp#1980) This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp. The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function. Closes basecamp#1977
malik-na
pushed a commit
to malik-na/omarchy-mac
that referenced
this pull request
Nov 16, 2025
…-or-focus-webapp script (basecamp#1980) This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp. The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function. Closes basecamp#1977
bjarneo
pushed a commit
to bjarneo/omarchy
that referenced
this pull request
Nov 19, 2025
…-or-focus-webapp script (basecamp#1980) This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp. The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function. Closes basecamp#1977
andrew-a-hale
pushed a commit
to andrew-a-hale/omarchy
that referenced
this pull request
Nov 29, 2025
…-or-focus-webapp script (basecamp#1980) This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp. The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function. Closes basecamp#1977
gocs
pushed a commit
to gocs/omarchy
that referenced
this pull request
Dec 7, 2025
…-or-focus-webapp script (basecamp#1980) This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp. The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function. Closes basecamp#1977
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves:
This change addresses the reported issue where the omarchy-launch-or-focus-webapp script failed to correctly process and pass additional flags, such as --profile-directory, to the underlying web app launcher. This resulted in web apps not opening with the intended user profile or configuration.
How it works: The script is modified to use shift to correctly separate the [window-pattern] from the subsequent arguments ([url] [flags...]). It then passes all remaining arguments as the single launch command to omarchy-launch-or-focus.
Related Issue: Closes #1977