Skip to content

Fix: Allow passing flags/arguments to omarchy-launch-or-focus-webapp script#1980

Merged
dhh merged 1 commit into
basecamp:devfrom
meirdick:feature/launch-or-focus-webapp-flags
Oct 6, 2025
Merged

Fix: Allow passing flags/arguments to omarchy-launch-or-focus-webapp script#1980
dhh merged 1 commit into
basecamp:devfrom
meirdick:feature/launch-or-focus-webapp-flags

Conversation

@meirdick

Copy link
Copy Markdown
Contributor

What it solves:
This change addresses the reported issue where the omarchy-launch-or-focus-webapp script failed to correctly process and pass additional flags, such as --profile-directory, to the underlying web app launcher. This resulted in web apps not opening with the intended user profile or configuration.

How it works: The script is modified to use shift to correctly separate the [window-pattern] from the subsequent arguments ([url] [flags...]). It then passes all remaining arguments as the single launch command to omarchy-launch-or-focus.

Related Issue: Closes #1977

…-or-focus-webapp script

This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp.

The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function.

Closes basecamp#1977
@Prajwal-Prathiksh

Copy link
Copy Markdown
Contributor

#1266 - and this seem to be solving similar problems.

@dhh
dhh changed the base branch from master to dev October 6, 2025 19:53
@dhh
dhh merged commit 2c14252 into basecamp:dev Oct 6, 2025
dhcrzf pushed a commit to dhcrzf/omarchy that referenced this pull request Oct 21, 2025
…-or-focus-webapp script (basecamp#1980)

This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp.

The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function.

Closes basecamp#1977
zachasme pushed a commit to zachasme/omarchy that referenced this pull request Oct 27, 2025
…-or-focus-webapp script (basecamp#1980)

This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp.

The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function.

Closes basecamp#1977
guirossibrum pushed a commit to guirossibrum/ArchGui that referenced this pull request Oct 30, 2025
…-or-focus-webapp script (basecamp#1980)

This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp.

The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function.

Closes basecamp#1977
@patroza

patroza commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

I had to change the implementation like so for it to work well for me, without it, the -or-focus variant would not work correctly..

app=$1
rest=${@:2}
exec setsid uwsm-app -- $(sed -n 's/^Exec=\([^ ]*\).*/\1/p' {~/.local,~/.nix-profile,/usr}/share/applications/$browser 2>/dev/null | head -1) --app="$app" "$rest"

malik-na pushed a commit to malik-na/omarchy-mac that referenced this pull request Nov 1, 2025
…-or-focus-webapp script (basecamp#1980)

This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp.

The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function.

Closes basecamp#1977
malik-na pushed a commit to malik-na/omarchy-mac that referenced this pull request Nov 16, 2025
…-or-focus-webapp script (basecamp#1980)

This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp.

The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function.

Closes basecamp#1977
bjarneo pushed a commit to bjarneo/omarchy that referenced this pull request Nov 19, 2025
…-or-focus-webapp script (basecamp#1980)

This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp.

The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function.

Closes basecamp#1977
andrew-a-hale pushed a commit to andrew-a-hale/omarchy that referenced this pull request Nov 29, 2025
…-or-focus-webapp script (basecamp#1980)

This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp.

The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function.

Closes basecamp#1977
gocs pushed a commit to gocs/omarchy that referenced this pull request Dec 7, 2025
…-or-focus-webapp script (basecamp#1980)

This resolves the issue where extra arguments like Chromium's --profile-directory were ignored when launching a web app via omarchy-launch-or-focus-webapp.

The script now uses 'shift' to isolate the window pattern ($1) and passes all remaining arguments ($@), which include the URL and flags, to the omarchy-launch-webapp function.

Closes basecamp#1977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

omarchy-launch-or-focus-webapp does not accept flags for profile-directory

4 participants