Suppress VS Code CLI deprecation warnings during theme setup#608
Open
chriscupas wants to merge 2 commits into
Open
Suppress VS Code CLI deprecation warnings during theme setup#608chriscupas wants to merge 2 commits into
chriscupas wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates VS Code CLI extension installation commands to suppress Node.js deprecation warnings by setting NODE_OPTIONS=...--no-deprecation for the code invocation.
Changes:
- Add
NODE_OPTIONSwith--no-deprecationwhen installing extensions viacode. - Quote
"$VSC_EXTENSION"in the theme setup script to avoid word-splitting/globbing issues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| themes/set-vscode-theme.sh | Sets NODE_OPTIONS for the code --install-extension call and improves quoting of the extension variable. |
| install/desktop/app-vscode.sh | Sets NODE_OPTIONS for the default theme extension installation via code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
DEP0169warnings fromurl.parse()during VS Code extension installation, which made the workflow noisy