Ioskeley font#602
Open
LomTuby wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the Ioskeley font as a selectable programming font in the Omakub font picker and provides an Alacritty font config for it. The PR also rotates Spotify’s APT signing key (via both the Spotify installer and a migration for existing installs).
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Add “Ioskeley” to the font selection menu and install it from an upstream release zip.
- Add an Alacritty font config for the IoskeleyMono Nerd Font family.
- Update Spotify’s Debian repo signing key and add a migration to update existing machines.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| migrations/1770656330.sh | Adds a migration to refresh Spotify’s APT key/repo entry when Spotify is already configured. |
| install/desktop/optional/app-spotify.sh | Rotates the Spotify signing key used during installation. |
| configs/alacritty/fonts/IoskeleyMono.toml | New Alacritty font definition for IoskeleyMono Nerd Font. |
| bin/omakub-sub/font.sh | Adds “Ioskeley” as a selectable font option and wires it to download/install logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+7
| # Update Spotify GPG key if the repository is present | ||
| if [ -f /etc/apt/sources.list.d/spotify.list ]; then | ||
| echo "Updating Spotify GPG key..." | ||
| curl -sS https://download.spotify.com/debian/pubkey_5384CE82BA52C83A.gpg | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg | ||
| echo "deb [signed-by=/etc/apt/trusted.gpg.d/spotify.gpg] https://repository.spotify.com stable non-free" | sudo tee /etc/apt/sources.list.d/spotify.list |
| # Update Spotify GPG key if the repository is present | ||
| if [ -f /etc/apt/sources.list.d/spotify.list ]; then | ||
| echo "Updating Spotify GPG key..." | ||
| curl -sS https://download.spotify.com/debian/pubkey_5384CE82BA52C83A.gpg | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg |
| if [ ! -f /etc/apt/sources.list.d/spotify.list ]; then | ||
| [ -f /etc/apt/trusted.gpg.d/spotify.gpg ] && sudo rm /etc/apt/trusted.gpg.d/spotify.gpg | ||
| curl -sS https://download.spotify.com/debian/pubkey_C85668DF69375001.gpg | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg | ||
| curl -sS https://download.spotify.com/debian/pubkey_5384CE82BA52C83A.gpg | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Ioskeley as a font choice