Feat/dev align provisioning access#49
Merged
basebandit merged 12 commits intoJun 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Drop the duplicate dev executor role
environments/dev/iam.tfcreatedterraform-executor-devvia the oldmodules/terraform-executor-role+ sharedgha-bootstrap-rolepattern. That issuperseded by
bootstrap/provisioning-access, which already owns per-accountGitHubActionsTerraformRole(GitHub OIDC) andTerraformExecutionRole. In CI,GitHub OIDC assumes
GitHubActionsTerraformRolein the dev account directly, sothe dev provider needs no executor role of its own.
environments/dev/iam.tfand itsexecutor_role_arnoutput.bootstrap_role_arnvariable.2. Rename the ArgoCD install root
environments/dev/bootstrap/collided with the infrastructure bootstrap layer(
infrastructure/bootstrap/). "bootstrap" is for infrastructure, not Kubernetesdeployments. Renamed to
environments/dev/argocd/(state keydev/bootstrap→dev/argocd); updated references in the cluster root and chart README.Both dev roots
terraform validatecleanly.