Skip to content

feat(eks): expose configurable variables documented in README#38

Merged
basebandit merged 3 commits into
chore/refactor-with-enhancementsfrom
copilot/sub-pr-37
Feb 9, 2026
Merged

feat(eks): expose configurable variables documented in README#38
basebandit merged 3 commits into
chore/refactor-with-enhancementsfrom
copilot/sub-pr-37

Conversation

Copilot AI commented Feb 9, 2026

Copy link
Copy Markdown

The EKS module README documented variables like kubernetes_version, endpoint_public_access, endpoint_private_access, enable_cluster_creator_admin_permissions, and authentication_mode, but these were hardcoded in the module implementation rather than exposed as inputs.

Changes:

  • Added 5 missing input variables to variables.tf with defaults matching the previously hardcoded values
  • Updated main.tf to use variables instead of literals
  • Maintains backward compatibility—existing configurations work unchanged

Before:

# main.tf - hardcoded values
kubernetes_version = "1.32"
endpoint_public_access  = false
endpoint_private_access = true

After:

# variables.tf - configurable with sensible defaults
variable "kubernetes_version" {
  description = "Kubernetes version for the EKS cluster"
  type        = string
  default     = "1.32"
}

variable "endpoint_public_access" {
  description = "Enable public API server endpoint access"
  type        = bool
  default     = false
}
# ... additional variables

# main.tf - uses variables
kubernetes_version = var.kubernetes_version
endpoint_public_access  = var.endpoint_public_access
endpoint_private_access = var.endpoint_private_access

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…tion

Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on refactor enhancements from previous PR review feat(eks): expose configurable variables documented in README Feb 9, 2026
Copilot AI requested a review from basebandit February 9, 2026 05:46
@basebandit basebandit marked this pull request as ready for review February 9, 2026 05:58
@basebandit basebandit merged commit 4c24544 into chore/refactor-with-enhancements Feb 9, 2026
@basebandit basebandit deleted the copilot/sub-pr-37 branch February 9, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants