Skip to content

fix: add missing ethers import in flashblocks Ethers.js example#1561

Open
Arvuno wants to merge 1 commit into
base:masterfrom
Arvuno:pr/flashblocks-ethers-import
Open

fix: add missing ethers import in flashblocks Ethers.js example#1561
Arvuno wants to merge 1 commit into
base:masterfrom
Arvuno:pr/flashblocks-ethers-import

Conversation

@Arvuno
Copy link
Copy Markdown

@Arvuno Arvuno commented May 31, 2026

The Ethers.js code example in the flashblocks app-integration guide uses ethers.JsonRpcProvider, ethers.Wallet, and ethers.parseEther without importing the library. Every other code block in the same file (Wagmi, Viem) includes its import statement — only Ethers.js was missing it.

A developer copying this code will get 'ReferenceError: ethers is not defined'.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants