Create route calculation benchmark tests using pytest-benchmark - #358
Open
thomaszwagerman wants to merge 6 commits into
Open
Create route calculation benchmark tests using pytest-benchmark#358thomaszwagerman wants to merge 6 commits into
thomaszwagerman wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an eye on #280, set up some benchmark tests for us to routinely compare against when developing performance improvements to routing calculations.
Also adding a benchmark action which will compare performance against
main.mainwill only have a baseline once this is merged in, so currently it is not comparing against anything. The "acceptable" threshold is a 10% regression from the baseline (no idea if that is sensible? but let's try it), the CI will fail if this is exceeded.When merging to
maina PR will be opened with an updated baseline - a human can then decide if the baseline should be updated. The reason for not doing this automatically is if there is a subtle drift (say of 8%), and then another, another etc. we still get a regression over time without noticing.